[albatross-users] [patch] get_uri -> get_path_info changes

[Dave Cole]

>>>>> "Matt" == Matt Goodall <matt at pollenation.net> writes:

Matt> In light of the problem Sheila found, below are some comments on
Matt> the patches.

Matt> On Tue, 2003-07-08 at 18:03, Matt Goodall wrote:

>> 01.base_url.patch - a patch to fix my previous patch. Already
>> applied by Dave I think.

Matt> This was clearly the wrong solution as the original base_url
Matt> patch did not consider that the base_url might not be absolute.

Now back to this in Application.__init__():

        # Use a base_url of '/' if not provided
        if base_url:
            self.__base_url = base_url
        else:
            self.__base_url = '/'

>> 03.httpdapp.patch - simplified version of Request.get_uri().

Matt> Not necessary but still an improvement. It's kind of irrelevant
Matt> though as it doesn't work with the old base_url stuff.

Applied (already said this in other email).

>> 04.get_path_info.patch - introduces get_path_info() methods into
>> the request adapters.

Matt> Not much point with 05 but it may be useful anyway. Dave/Andrew,
Matt> it's up to you.

Applied.

>> 05.use_path_info.patch - switch from using Request.get_uri() to
>> Request.get_path_info(). This affects how the random page loader
>> works and how the current and redirect urls are calculated.

Matt> Completely breaks redirect_url when the base_url is not
Matt> absolute. Do not apply.

Not applied.

- Dave

-- 
http://www.object-craft.com.au